Should I ask my patent attorney to sign a non-disclosure agreement?

You can ask, but it is most often not necessary. Patent attorneys deal with confidential information all day long and must preserve the confidences and secrets of a client.